formatting empty where clauses when there are return types#6167
Open
mu001999 wants to merge 2 commits intorust-lang:mainfrom
Open
formatting empty where clauses when there are return types#6167mu001999 wants to merge 2 commits intorust-lang:mainfrom
mu001999 wants to merge 2 commits intorust-lang:mainfrom
Conversation
ytmimi
requested changes
May 20, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Given that rustfmt's current behavior is to leave empty where clauses as is, this change would need to be version gated.
I'm also curious how this change impacts comments before and after empty where clauses. For example:
fn foo() -> () /* comment */ where {}
fn bar() -> () where /* comment */ {}
mu001999
force-pushed
the
master
branch
2 times, most recently
from
a18fd76 to
4771809
Compare
Contributor
Author
|
@ytmimi friendly ping ;) |
jieyouxu
added
the
S-waiting-on-review
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug, see rust-lang/rust#125242 (comment)