Merged
Conversation
30da8d9 to
384aaa1
Compare
Darksonn
reviewed
Mar 5, 2026
CHANGELOG.md
Outdated
Comment on lines
+6
to
+9
| * **POTENTIALLY BREAKING** Updated to windows-sys v0.61. windows-sys increased | ||
| their MSRV to 1.71, while socket2 is on 1.70. It's possible to downgrade | ||
| window-sys using the following command to stay on Rust 1.70: | ||
| `cargo update windows-sys --precise 0.60.2` |
Member
There was a problem hiding this comment.
I'd split the note about MSRV out from the bullet point.
Suggested change
| * **POTENTIALLY BREAKING** Updated to windows-sys v0.61. windows-sys increased | |
| their MSRV to 1.71, while socket2 is on 1.70. It's possible to downgrade | |
| window-sys using the following command to stay on Rust 1.70: | |
| `cargo update windows-sys --precise 0.60.2` | |
| * Support windows-sys v0.61 in addition to v0.60. | |
| The MSRV of windows-sys v0.61 is 1.71. To use socket2 with its MSRV of 1.70, please use windows-sys v0.60: `cargo update windows-sys --precise 0.60.2` |
Collaborator
Author
There was a problem hiding this comment.
I changed the suggestion a little bit keeping the potentially breaking callout as I want to be explicit.
384aaa1 to
adb03cd
Compare
Darksonn
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.