add ACLE random number generation intrinsics#2050
add ACLE random number generation intrinsics#2050folkertdev wants to merge 3 commits intorust-lang:mainfrom
Conversation
|
cc @adamgemmell to check that this makes sense. Internally the feature appears to be called |
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
crates/core_arch/src/aarch64/rand.rs
Outdated
|
|
||
| unsafe extern "unadjusted" { | ||
| #[cfg_attr( | ||
| any(target_arch = "aarch64", target_arch = "arm64ec"), |
There was a problem hiding this comment.
I don't think you need these cfg_attrs here, as this is the aarch64 module.
There was a problem hiding this comment.
right. I based this off of mte.rs so I've removed the cfg_attrs there too.
folkertdev
force-pushed
the
aarch64-rand
branch
3 times, most recently
from
0cf01e1 to
709ece1
Compare
crates/core_arch/src/aarch64/mte.rs
Outdated
| /// SAFETY: See `__arm_mte_create_random_tag`. | ||
| #[inline] | ||
| #[target_feature(enable = "mte")] | ||
| #[cfg_attr(test, assert_instr(addg))] |
There was a problem hiding this comment.
| #[cfg_attr(test, assert_instr(addg))] | |
| #[cfg_attr(test, assert_instr(addg, OFFSET=0))] |
There was a problem hiding this comment.
The functions here are all generic, which is why the tests were separate I think. I've added a comment now to make that clearer.
folkertdev
force-pushed
the
aarch64-rand
branch
from
709ece1 to
57e354c
Compare
folkertdev
force-pushed
the
aarch64-rand
branch
from
57e354c to
d6ffea0
Compare
3 participants
tracking issue: rust-lang/rust#153514