Unify lazy atomics in entropy backends #804
Open
+161
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ad-hoc atomic lazy caches with shared lazy helpers in the Linux/Android fallback, NetBSD, RDRAND, and RNDR backends. Add `LazyPtr` alongside `LazyUsize` and `LazyBool` so pointer and boolean caches use the same initialization contract. This reduces duplicated cache logic and keeps backend probing/fallback semantics aligned while preserving the existing retry-until-cached behavior.
newpavlov
reviewed
Feb 4, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
I would prefer to keep the NonNull stuff.
|
|
||
| /// Lazily initializes a cached bool; reuses `LazyUsize` to avoid sentinel | ||
| /// issues with `AtomicBool`. | ||
| #[allow(dead_code)] |
Member
There was a problem hiding this comment.
Use #![allow(dead_code)] for the whole module.
|
|
||
| // Identical to LazyUsize except with bool instead of usize. | ||
| lazy_atomic!(LazyUsize, AtomicUsize, usize, usize::MAX); | ||
| lazy_atomic!(LazyPtr<T>, AtomicPtr<T>, *mut T, ptr::dangling_mut()); |
Member
There was a problem hiding this comment.
Why use dangligng pointer instead of null?
| struct LazyUsize(AtomicUsize); | ||
| macro_rules! lazy_atomic { | ||
| ($name:ident $(<$($gen:ident),+>)?, $atomic:ty, $value:ty, $uninit:expr) => { | ||
| // This structure represents a lazily initialized static usize value. Useful |
Member
There was a problem hiding this comment.
This doc is not correct for LazyPtr. Probably better to just move the description to the module-level docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ad-hoc atomic lazy caches with shared lazy helpers in the Linux/Android fallback, NetBSD, RDRAND, and RNDR backends. Add
LazyPtralongsideLazyUsizeandLazyBoolso pointer and boolean caches use the same initialization contract.This reduces duplicated cache logic and keeps backend probing/fallback semantics aligned while preserving the existing retry-until-cached behavior.