Conversation
| [tool.setuptools_scm] | ||
| root = "../.." | ||
| tag_regex = "^essimaging/(?P<version>[vV]?\\d+(?:\\.\\d+)*(?:[._-]?\\w+)*)$" | ||
| tag_regex = "^essimaging/(?P<version>.*)$" |
There was a problem hiding this comment.
Not sure it should be this loose. Can you give an example why we can't have stricter requirements on the tag? At least something like ^essimaging/(?P<version>[vV]?\d+.*)$ to ensure the tag starts with a number (or v`).
There was a problem hiding this comment.
I'm fine with that too. I just wanted to remove the escapes as much as possible. I'm not sure if these things affects different systems differently?
There was a problem hiding this comment.
Which escapes are you talking about?
There was a problem hiding this comment.
^essimaging/(?P<version>[vV]?\\d+.*)$
Like this right?
We decided not to use v so shouldn't it be like this?
^essimaging/(?P<version>\\d+.*)$
There was a problem hiding this comment.
The double \
This should be independent of the OS. It's Python-specific.
^essimaging/(?P<version>[vV]?\\d+.*)$Like this right?
Yes.
We decided not to use v so shouldn't it be like this?
No harm allowing a v IMHO. But if we want to be strict, then yes, we can leave it out.
3 participants
I think the more strict regex seems to create issues on certain systems. This should also make it easier to debug.