Fix flaky test_idle_heartbeat and CI workflow YAML syntax#699
Open
dkropachev wants to merge 2 commits intomasterfrom
Open
Fix flaky test_idle_heartbeat and CI workflow YAML syntax#699dkropachev wants to merge 2 commits intomasterfrom
dkropachev wants to merge 2 commits intomasterfrom
Conversation
The test_idle_heartbeat test could fail with a KeyError when shard-aware reconnection replaced connections during the sleep interval. Skip connections not present in the original snapshot. Also fix a trailing whitespace/dash in integration-tests.yml that caused a YAML syntax issue in the paths-ignore list.
dkropachev
force-pushed
the
fix/idle-heartbeat-and-ci-yaml
branch
from
6357f5e to
d1ae102
Compare
…rtion Two issues caused this test to be flaky: 1. wait_for_all_pools only waits for the first connection per host. Shard-aware connections to remaining shards are opened asynchronously. When these complete during the test's sleep interval, they replace existing connections causing KeyError on the request_ids snapshot. Fix: add a helper that polls until all shard connections are established, called after connect(). 2. execute_concurrent sent only len(hosts) queries, but with shard-aware routing each query hits one specific shard, leaving other shards' connections idle. The assertion that ALL connections are non-idle then fails. Fix: send more queries (2x num_connections) and relax assertion to check that at least some non-control connections became non-idle.
dkropachev
force-pushed
the
fix/idle-heartbeat-and-ci-yaml
branch
from
d1ae102 to
be5d3f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_idle_heartbeatflaky failure (KeyError) caused by shard-aware reconnection replacing connections during the sleep interval. The test now skips connections that weren't in the original snapshot.integration-tests.ymlpaths-ignorelist that caused a YAML syntax issue.Test plan
test_idle_heartbeatno longer fails withKeyErrorin CI