Fix TwistedConnection close() not setting last_error#703
Draft
dkropachev wants to merge 1 commit intomasterfrom
Draft
Fix TwistedConnection close() not setting last_error#703dkropachev wants to merge 1 commit intomasterfrom
dkropachev wants to merge 1 commit intomasterfrom
Conversation
When close() is called during connection setup (before connected_event is set), factory() could return a dead connection because last_error was not set. Copy the pattern from asyncore where last_error is set in close() when the connection handshake hasn't completed yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TwistedConnection.close() not setting
last_errorwhen the connection is closed during setup.connected_eventis set,factory()could return a dead connection becauselast_errorwas never setChanges
last_errorinclose()whenconnected_eventis not yet set (matching the asyncore pattern)Test plan
tests/unit/io/test_twistedreactor.pypassesRefs #614