Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
=======================================
Coverage 48.32% 48.32%
=======================================
Files 671 671
Lines 50576 50580 +4
=======================================
+ Hits 24439 24443 +4
Misses 23998 23998
Partials 2139 2139
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
philipsu522
reviewed
Feb 13, 2026
| }) | ||
| } | ||
|
|
||
| func TestUnjail(t *testing.T) { |
Contributor
There was a problem hiding this comment.
should we verify events are emitted?
should we add some more test cases? thinking:
- calling unjail on a non-validator
- calling unjail with improper params (not enough fees, wrong key...etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add
unjailfunction to the staking precompileTesting performed to validate your change
unit test