Skip to content

removed autorestart cooldowns#2887

Open
pompon0 wants to merge 6 commits intomainfrom
gprusak-cooldown
Open

removed autorestart cooldowns#2887
pompon0 wants to merge 6 commits intomainfrom
gprusak-cooldown

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Feb 13, 2026

These cooldowns provide no value, by keeping the process alive while it does not make any sense. Also there was a semantic mismatch between blocksync sending at most 1 message to the restartCh, and WaitForQuitSignals which ignored messages until cooldown has passed. I think that cooldown in blocksync logic was exactly trying to avoid sending messages when WaitForQuitSignals could have ignored them, which is a very fragile way of doing things.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 16, 2026, 12:21 PM

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 26.08696% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.16%. Comparing base (927626b) to head (ee297a9).

Files with missing lines Patch % Lines
sei-cosmos/server/start.go 0.00% 16 Missing ⚠️
sei-tendermint/cmd/tendermint/commands/run_node.go 0.00% 9 Missing ⚠️
sei-cosmos/server/util.go 57.14% 0 Missing and 3 partials ⚠️
sei-tendermint/test/e2e/node/main.go 0.00% 2 Missing ⚠️
sei-tendermint/cmd/tendermint/main.go 0.00% 1 Missing ⚠️
sei-tendermint/internal/statesync/reactor.go 50.00% 1 Missing ⚠️
sei-tendermint/node/public.go 50.00% 1 Missing ⚠️
sei-tendermint/rpc/test/helpers.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
- Coverage   57.17%   57.16%   -0.02%     
==========================================
  Files        2091     2091              
  Lines      171543   171528      -15     
==========================================
- Hits        98081    98051      -30     
+ Misses      64713    64708       -5     
- Partials     8749     8769      +20     
Flag Coverage Δ
sei-chain 52.63% <21.73%> (+<0.01%) ⬆️
sei-cosmos 48.13% <17.39%> (-0.07%) ⬇️
sei-db 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/config/db.go 100.00% <ø> (ø)
sei-tendermint/internal/blocksync/reactor.go 61.56% <100.00%> (+0.11%) ⬆️
sei-tendermint/node/node.go 59.24% <100.00%> (+0.27%) ⬆️
sei-tendermint/node/seed.go 46.93% <ø> (+1.06%) ⬆️
sei-tendermint/cmd/tendermint/main.go 0.00% <0.00%> (ø)
sei-tendermint/internal/statesync/reactor.go 70.28% <50.00%> (+0.28%) ⬆️
sei-tendermint/node/public.go 52.38% <50.00%> (+2.38%) ⬆️
sei-tendermint/rpc/test/helpers.go 77.27% <0.00%> (-3.01%) ⬇️
sei-tendermint/test/e2e/node/main.go 0.00% <0.00%> (ø)
sei-cosmos/server/util.go 62.29% <57.14%> (-6.30%) ⬇️
... and 2 more

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bigger change than I was expecting: it fixes the bug discussed in Slack, and fundamentally changes the behaviour of the node. In that, after this change the process errors out instead of softly restarting the reactor in-process.

This is clearly simpler, but it means that without an external process supervisor there is no "restart" after self-remediation. The process simply dies.

I probably would have broken this into two PRs, just for the sake of release notes: one to fix the clear bug regarding restart trigger during cooldown, and one to remove it. At the very least this needs a mention in the next release notes for 6.3 patch release. Cc @philipsu522

No blockers.

@pompon0 pompon0 requested a review from philipsu522 February 13, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants