Move CLAUDE.md contents to AGENTS.md#2888
Open
pdrobnjak wants to merge 6 commits intopd/benchmark-profiling-improvementsfrom
Open
Move CLAUDE.md contents to AGENTS.md#2888pdrobnjak wants to merge 6 commits intopd/benchmark-profiling-improvementsfrom
pdrobnjak wants to merge 6 commits intopd/benchmark-profiling-improvementsfrom
Conversation
Baseline: 8600 TPS median with GIGA_EXECUTOR=true GIGA_OCC=true. Key findings: - CacheMultiStore snapshot allocation is #1 target (15 GB, 27% of function) - cachekv.NewStore creates 9 GB of sync.Map objects per 30s sample - GC overhead (~24% CPU) is driven by allocation pressure - Lock contention (30.7% CPU) partially secondary to GC/alloc Candidate optimizations: sync.Pool for cachekv.Store, lazy per-store creation, replace sync.Map with regular map in giga path, cache block-level constants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace per-tx cachekv.Store allocation with sync.Pool recycling for both standard and giga variants. Add CacheMultiStore.Release() and ReleaseDB() to return stores to pools at lifecycle boundaries (Cleanup, RevertToSnapshot, CleanupForTracer). Release replaced stores in SetKVStores/SetGigaKVStores and unused db store in OCC scheduler. Reset() replaces sync.Map fields with fresh instances (not Clear(), which is slower due to internal trie node walking and causes more allocations when repopulated). Targeting the #1 flat allocator from profiling: cachekv.NewStore at 9 GB / 157M objects over 30s at 8600 TPS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit dbd6ad5.
CLAUDE.md is only read by Claude Code, while AGENTS.md is recognized by multiple agentic coding tools. Each CLAUDE.md now references its co-located AGENTS.md so the context is available to all agents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Instructs agents to always keep content in AGENTS.md files and only references in CLAUDE.md files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
changed the base branch from
main
to
pd/benchmark-profiling-improvements
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pd/benchmark-profiling-improvements #2888 +/- ##
=======================================================================
- Coverage 57.20% 57.17% -0.03%
=======================================================================
Files 2091 2091
Lines 171173 171173
=======================================================================
- Hits 97912 97861 -51
- Misses 64551 64602 +51
Partials 8710 8710
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdfiles alongside eachCLAUDE.md(root,benchmark/,giga/tests/) containing the original instructionsCLAUDE.mdwith a reference to its co-locatedAGENTS.mdAGENTS.mdis recognized by multiple agentic coding tools, making context available beyond just Claude CodeTest plan
AGENTS.mdfiles contain correct content in each directoryCLAUDE.mdfiles reference their respectiveAGENTS.md🤖 Generated with Claude Code