Skip to content

Pin Node.js 24 in release workflow#305

Merged
codebycarson merged 1 commit intomainfrom
patch/oidc-release-action
Feb 12, 2026
Merged

Pin Node.js 24 in release workflow#305
codebycarson merged 1 commit intomainfrom
patch/oidc-release-action

Conversation

@codebycarson
Copy link
Collaborator

@codebycarson codebycarson commented Feb 12, 2026

This pull request makes a minor update to the Node.js setup step in the release workflow. The change specifies Node.js version 24 directly instead of using the .nvmrc file, and clarifies the step's purpose for npm OIDC publishing.Replace node-version-file: '.nvmrc' with an explicit node-version: '24' in the release GitHub Actions workflow and rename the step to 'Setup Node.js (for npm OIDC publishing)'. This ensures the workflow uses Node 24 for npm OIDC publishing rather than relying on the repo's .nvmrc.

Example comes from here: https://docs.npmjs.com/trusted-publishers#step-2-configure-your-cicd-workflow

Replace node-version-file: '.nvmrc' with an explicit node-version: '24' in the release GitHub Actions workflow and rename the step to 'Setup Node.js (for npm OIDC publishing)'. This ensures the workflow uses Node 24 for npm OIDC publishing rather than relying on the repo's .nvmrc.
@codebycarson codebycarson requested a review from Copilot February 12, 2026 13:45
@codebycarson codebycarson self-assigned this Feb 12, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: b57ccef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions release workflow to use an explicit Node.js version (24) for the setup-node step, rather than reading the version from .nvmrc, and clarifies the step name for npm OIDC publishing.

Changes:

  • Pin actions/setup-node@v4 to node-version: '24' in the release workflow (instead of node-version-file: '.nvmrc').
  • Rename the step to clarify it’s intended for npm OIDC publishing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +26 to 30
- name: Setup Node.js (for npm OIDC publishing)
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: '24'
registry-url: 'https://registry.npmjs.org'
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release workflow now pins Node.js 24 while the rest of CI (e.g. checks.yml/coverage.yml) still uses .nvmrc (currently v20). This means the build+publish path can run on an untested Node major, which can lead to release-only failures or different build output. Consider aligning versions (update .nvmrc to 24, or switch other workflows to 24 / add a Node matrix including 24) so release runs on a version covered by CI.

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.69%. Comparing base (1bdef35) to head (b57ccef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          83       83           
  Lines        1305     1305           
  Branches      215      215           
=======================================
  Hits         1040     1040           
  Misses        259      259           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebycarson codebycarson merged commit 184d715 into main Feb 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants