Conversation
Replace node-version-file: '.nvmrc' with an explicit node-version: '24' in the release GitHub Actions workflow and rename the step to 'Setup Node.js (for npm OIDC publishing)'. This ensures the workflow uses Node 24 for npm OIDC publishing rather than relying on the repo's .nvmrc.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to use an explicit Node.js version (24) for the setup-node step, rather than reading the version from .nvmrc, and clarifies the step name for npm OIDC publishing.
Changes:
- Pin
actions/setup-node@v4tonode-version: '24'in the release workflow (instead ofnode-version-file: '.nvmrc'). - Rename the step to clarify it’s intended for npm OIDC publishing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup Node.js (for npm OIDC publishing) | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| node-version: '24' | ||
| registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
Release workflow now pins Node.js 24 while the rest of CI (e.g. checks.yml/coverage.yml) still uses .nvmrc (currently v20). This means the build+publish path can run on an untested Node major, which can lead to release-only failures or different build output. Consider aligning versions (update .nvmrc to 24, or switch other workflows to 24 / add a Node matrix including 24) so release runs on a version covered by CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 83 83
Lines 1305 1305
Branches 215 215
=======================================
Hits 1040 1040
Misses 259 259
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request makes a minor update to the Node.js setup step in the release workflow. The change specifies Node.js version 24 directly instead of using the
.nvmrcfile, and clarifies the step's purpose for npm OIDC publishing.Replace node-version-file: '.nvmrc' with an explicit node-version: '24' in the release GitHub Actions workflow and rename the step to 'Setup Node.js (for npm OIDC publishing)'. This ensures the workflow uses Node 24 for npm OIDC publishing rather than relying on the repo's .nvmrc.Example comes from here: https://docs.npmjs.com/trusted-publishers#step-2-configure-your-cicd-workflow