Fix when Domain Name is currently set through DHCP#186
Open
flaviotorres wants to merge 2 commits intoseveas:mainfrom
Open
Fix when Domain Name is currently set through DHCP#186flaviotorres wants to merge 2 commits intoseveas:mainfrom
flaviotorres wants to merge 2 commits intoseveas:mainfrom
Conversation
…main_name is empty and hpilo_ca can't update. Avoiding loop.
seveas
reviewed
Aug 23, 2018
| # Note: Domain Name is currently set through DHCP, if enabled then domain_name is empty and hpilo_ca can't update. Avoiding loop. | ||
| if network_settings['dns_name'] != hn: | ||
| print("Hostname misconfigured on the ilo - hn:[%s] dn:[%s], fixing") % (network_settings['dns_name'], hn) | ||
| ilo.mod_network_settings(dns_name=hn, domain_name=dn) |
Owner
There was a problem hiding this comment.
This is still trying to update the domain name, isn't that incorrect?
Contributor
Author
There was a problem hiding this comment.
It will update the domain name if iLO is not set to use DHCP. The loop happens when iLO is set to use DHCP. See attached screenshot for better understanding.
Contributor
Author
|
Hello here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When domain name is set hpilo_ca was in loop because it can't update the domain. Adding a condition to check that, if enabled hpilo_ca will fix the hostname only and leave domain_name to be updated by DHCP