Re-design strr[c]spn(), to make it simpler and more useful#1559
Open
alejandro-colomar wants to merge 2 commits intoshadow-maint:masterfrom
Open
Re-design strr[c]spn(), to make it simpler and more useful#1559alejandro-colomar wants to merge 2 commits intoshadow-maint:masterfrom
alejandro-colomar wants to merge 2 commits intoshadow-maint:masterfrom
Conversation
… end Instead of returning the offset from the start of the string, return the length of the span counting from the end. This makes the name of the function more representative of its behavior, and also makes the functions more useful: one can use them as booleans to determine whether a string ends in a set of characters or not. if (strrspn(s, "xyz")) // Does 's' end in any chars of "xyz"? Currently, the only uses of strr[c]spn() are for implementing stpr[c]spn(), so we had to update those too. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
strrspn
branch
from
f7aa972 to
adb25ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc: @kees
Revisions:
v1b