This repository was archived by the owner on Aug 14, 2024. It is now read-only.
New version of rubocop-performance (1.20.0) produced dependency conflicts#143
Closed
depfu[bot] wants to merge 1 commit intomasterfrom
Closed
New version of rubocop-performance (1.20.0) produced dependency conflicts#143depfu[bot] wants to merge 1 commit intomasterfrom
depfu[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
Closed in favor of #145. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.
Please take a look at the exact failure to figure out if this is something you need to work on.
The bundler error message was:
What changed?
✳️ rubocop-performance (~> 1.7.0 → ~> 1.20.0) · Repo · Changelog
Release Notes
1.20.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 35 commits:
Cut 1.20.0Update ChangelogMerge pull request #423 from koic/fix_false_positives_for_performance_times_map[Fix #421] Fix false positives for `Performance/TimesMap`Merge pull request #420 from koic/make_some_cop_aware_of_safe_navigation_operatorMerge pull request #418 from koic/support_optimized_string_dup_for_performance_unfreeze_stringMake some cops aware of safe navigation operatorRemove an useless code[Fix #384] Support optimized `String#dup` for `Performance/UnfreezeString`Merge pull request #402 from koic/make_performance_sum_aware_of_safe_navigation_operator[Fix #401] Make `Performance/Sum` aware of safe navigation operatorMerge pull request #398 from koic/migrate_to_gha_from_circleciMigrate to GitHub Actions from CircleCIMerge pull request #400 from fatkodima/enhance-string_include-with-===Enhance `Performance/StringInclude` to handle `===` methodMerge pull request #392 from fatkodima/reverse_each-more-safe-navigationFix a false negative for `Performance/ReverseEach` when safe navigation is between `reverse` and `each`Merge pull request #391 from fatkodima/improve-map_compact-for-safe-handlingImprove `Performance/MapCompact` to handle more safe navigation callsMerge pull request #388 from koic/add_ci_for_the_oldest_supported_rubocop_versionRequire RuboCop 1.30+ as runtime dependencyMerge pull request #387 from Earlopain/false-negative-string-identifier-argument[Fix #386] Fix a false negative for `Performance/StringIdentifierArgument`Merge pull request #381 from ydakuka/update-links[Docs] Revise linksMerge pull request #380 from koic/require_rubocop_ast_1_30Require RuboCop AST 1.30.0+Add a project specMerge pull request #378 from ryym/update_doc_for_performance_countUpdate the doc for `Performance/Count`Explicitly add `require 'rubocop/rake_task'` for the rake task example of READMEMerge pull request #375 from koic/fix_an_error_for_performance_map_method_chain[Fix #374] Fix an error for `Performance/MapMethodChain`Fix duplicate contributor names when generating changelogSwitch back docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands