Add missing pthread.h in rtpp_proc_async #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation error for missing pthread_t type name.
rtpp_proc_async.h:44:34: error: unknown type name 'pthread_t'
44 | void rtpp_proc_async_setprocname(pthread_t thread_id, const char *pname);
| ^~~~~~~~~
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Member
|
@Ansuel I'd prefer not to include .h from another .h since it pollutes name space. As such, could you please let me know which .c file specifically are you having issue with compiling? The error message that you included only lists .h. |
Contributor
Author
|
@sobomax well the problem is really in
for the unknown pthread_t |
Member
|
@Ansuel I've moved rtpp_proc_async_setprocname() into a separate file, so it can only be included into files that use it. This should eliminate the need to have pthread_t to be defined in many places. Please check and let me know if something is till not right. Thanks! |
Contributor
Author
|
Ok will sync with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation error for missing pthread_t type name.
rtpp_proc_async.h:44:34: error: unknown type name 'pthread_t'
44 | void rtpp_proc_async_setprocname(pthread_t thread_id, const char *pname);
| ^~~~~~~~~