Add support for AWS Query protocol in the client #1029
+1,672
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Feb 4, 2026
...query/src/it/java/software/amazon/smithy/java/aws/client/awsquery/AwsQueryProtocolTests.java
Outdated
Show resolved
Hide resolved
...squery/src/main/java/software/amazon/smithy/java/aws/client/awsquery/FormUrlEncodedSink.java
Show resolved
Hide resolved
| writePercentEncoded(0x80 | (c & 0x3F)); | ||
| } else if (Character.isHighSurrogate(c) && i + 1 < len) { | ||
| char low = s.charAt(++i); | ||
| if (Character.isLowSurrogate(low)) { |
Member
There was a problem hiding this comment.
What happens when it's not a low surrogate?
| import java.nio.ByteBuffer; | ||
| import java.util.Arrays; | ||
|
|
||
| final class FormUrlEncodedSink { |
Member
There was a problem hiding this comment.
Is this application/x-www-form-urlencoded or RFC 3986 encoding? Should document.
Contributor
Author
There was a problem hiding this comment.
The later, added comments.
|
|
||
| <T extends SerializableStruct> T deserialize(ShapeBuilder<T> builder) { | ||
| try (var codec = XmlCodec.builder() | ||
| .wrapperElements(List.of(operationName + "Response", operationName + "Result")) |
Member
There was a problem hiding this comment.
Can xmlName or whatever the trait is, change the wrapper names?
...ry/src/main/java/software/amazon/smithy/java/aws/client/awsquery/AwsQueryClientProtocol.java
Outdated
Show resolved
Hide resolved
| import software.amazon.smithy.java.xml.XmlUtil; | ||
| import software.amazon.smithy.model.shapes.ShapeId; | ||
|
|
||
| public final class AwsQueryClientProtocol extends HttpClientProtocol { |
Member
There was a problem hiding this comment.
We might want to be able to customize this slightly for "EC2 query". Could probably be a followup.
adwsingh
force-pushed
the
adwsingh/aws-query
branch
from
d8e82d4 to
91a9f85
Compare
rhernandez35
reviewed
Feb 4, 2026
...ry/src/main/java/software/amazon/smithy/java/aws/client/awsquery/AwsQueryFormSerializer.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/software/amazon/smithy/java/aws/client/awsquery/AwsQueryFormSerializer.java
Outdated
Show resolved
Hide resolved
adwsingh
force-pushed
the
adwsingh/aws-query
branch
from
d5c54b0 to
de51146
Compare
rhernandez35
approved these changes
Feb 11, 2026
Contributor
|
approved but disabled automerge so michael can review tomorrow |
kstich
approved these changes
Feb 11, 2026
| this.service = Objects.requireNonNull(service, "service is required"); | ||
| this.version = Objects.requireNonNull(version, "version is required"); | ||
| this.errorDeserializer = HttpErrorDeserializer.builder() | ||
| .codec(XmlCodec.builder().build()) |
Contributor
There was a problem hiding this comment.
Does this need to be different than the codec on the instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.