[ios] not calling activation callback on inactive gestures by akwasniewski · Pull Request #3986 · software-mansion/react-native-gesture-handler

akwasniewski · 2026-02-19T12:20:16Z

Description

Gestures always call activation callback upon finalizing, regardless of the previous state. This is intended for normal gestures, however for manually handled gestures we don't want to call it. This PR unifies the behaviour across platforms, GestureManager.finalize() won't call activation callback.

Test plan

Tested on the state manager example

…-reset

Copilot

Pull request overview

This PR fixes an issue where gestures were always calling the activation callback upon finalizing, regardless of their previous state. The fix ensures that manually handled gestures don't trigger the activation callback, unifying behavior across iOS and other platforms.

Changes:

Added a manualActivation parameter throughout the gesture handling call chain to distinguish manual state changes
Modified sendEventsInState to check both the parameter and instance variable before sending activation callbacks
Updated all gesture recognizer subclasses that override handleGesture:fromReset: to support the new parameter

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
RNGestureHandlerModule.mm	Pass `manualActivation:YES` when manually setting gesture state via `setGestureStateSync`
RNGestureHandler.mm	Add `manualActivation` parameter to gesture handling methods and update activation callback logic
RNGestureHandler.h	Declare new method signatures with `manualActivation` parameter
RNRotationHandler.m	Add overloaded `handleGesture:fromReset:manualActivation:` method
RNPinchHandler.m	Add overloaded `handleGesture:fromReset:manualActivation:` method
RNLongPressHandler.m	Add overloaded `handleGesture:fromReset:manualActivation:` method with platform-specific declarations
RNFlingHandler.m	Add overloaded `handleGesture:fromReset:manualActivation:` method for macOS version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/react-native-gesture-handler/apple/RNGestureHandler.mm

m-bert

Could you please merge recent updates? There were changes to handleGesture that should be considered in this PR

packages/react-native-gesture-handler/apple/RNGestureHandler.mm

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m

j-piasecki · 2026-02-23T07:35:11Z

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m

+  [_gestureHandler handleGesture:self fromReset:fromReset manualActivation:NO];
+}


Is this override needed at all? It doesn't change anything compared to the base implementation

Yes we need the default value one so that the selector works correctly (as in #3983) and we need to overload the one with all the arguements so that when called from stateManager it initializes the handler specific values (like previousTime in LongPress or scale in pinch).

In the PR you linked, the base one ((void)handleGesture:(nonnull id)recognizer;) is implemented once in the base class. Here, handlers have both - the base one, and the extended one - defined. The base one is exactly the same as the implementation in GestureHandler. Hover doesn't seem to override either, and I assume the selector works there, no?

ah right, I assume the override in Fling was used at some, but not anumore. Removed altogether in 1246b9d. The other overrides are needed though.

Why are they needed? They don't differ from the default implementation.

j-piasecki · 2026-02-23T07:35:35Z

packages/react-native-gesture-handler/apple/Handlers/RNLongPressHandler.m

 {
-  previousTime = CACurrentMediaTime();
-  [_gestureHandler handleGesture:recognizer fromReset:NO];
+  [self handleGesture:recognizer fromReset:fromReset manualActivation:NO];
 }


j-piasecki · 2026-02-23T07:35:47Z

packages/react-native-gesture-handler/apple/Handlers/RNPinchHandler.m

+{
+  [self handleGesture:recognizer fromReset:fromReset manualActivation:NO];
+}


j-piasecki · 2026-02-23T07:35:56Z

packages/react-native-gesture-handler/apple/Handlers/RNRotationHandler.m

+{
+  [self handleGesture:recognizer fromReset:fromReset manualActivation:NO];
+}


j-piasecki · 2026-02-23T07:37:50Z

packages/react-native-gesture-handler/apple/RNGestureHandler.mm

+    } else if (
+        state == RNGestureHandlerStateEnd && _lastState != RNGestureHandlerStateActive && !manualActivation &&
+        !_manualActivation) {


What's the end result here? onFinalize is invoked with didSucceed: true without going through activate/deactivate?

Yes, this unifies the behaviour across platforms. Previously we forced calling activation callback. Do we want to handle it differently?

I think if the user called onFinalize, rather than onFail he wants to have the onSuccess flag set to true (for whaterver reason), but if he wanted the activation callback he would have called StateManager.activate directly.

What do you mean by

I think if the user called onFinalize, rather than onFail

I don't recall having onFail in that context.

Sorry, I meant when they called GestureStateManager.finalize() rather than GestureStateManager,fail()

Is didSucceed: true consistent across platforms here?

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T08:58:28Z

packages/react-native-gesture-handler/apple/Handlers/RNLongPressHandler.m

 {
-  previousTime = CACurrentMediaTime();
-  [_gestureHandler handleGesture:recognizer fromReset:NO];
+  [_gestureHandler handleGesture:recognizer fromReset:NO manualActivation:NO];


previousTime is no longer updated in the handleGesture: action method, but getDuration relies on previousTime - startTime. Since handleGesture: is the selector registered as the recognizer's action, duration may stay near 0 or stale for the whole gesture. Consider updating previousTime here as well (or route handleGesture: through the fromReset:manualActivation: path that sets it).

Suggested change

[_gestureHandler handleGesture:recognizer fromReset:NO manualActivation:NO];

[self handleGesture:recognizer fromReset:NO manualActivation:NO];

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m

…ndler.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T09:49:39Z

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m

  return self;
 }

- (void)handleGesture:(NSPanGestureRecognizer *)gestureRecognizer
-{
-  [_gestureHandler handleGesture:self];
-}
-
 - (void)mouseDown:(NSEvent *)event
 {
  [super mouseDown:event];


In the macOS implementation of RNBetterSwipeGestureRecognizer, the recognizer is still created with initWithTarget:self action:@selector(handleGesture:), but handleGesture: is no longer present (it was removed in this change). When AppKit fires the action, this will crash with an unrecognized selector. Please re-add -handleGesture: to forward to _gestureHandler, or change the target/action to _gestureHandler like the iOS version.

Copilot · 2026-02-24T09:49:39Z

packages/react-native-gesture-handler/apple/RNGestureHandler.h

 - (void)handleGesture:(nonnull id)recognizer fromReset:(BOOL)fromReset;
+- (void)handleGesture:(nonnull id)recognizer fromReset:(BOOL)fromReset fromManual:(BOOL)fromManual;
 - (void)handleGesture:(nonnull id)recognizer inState:(RNGestureHandlerState)state;
+- (void)handleGesture:(nonnull id)recognizer inState:(RNGestureHandlerState)state fromManual:(BOOL)fromManual;


The new selector label fromManual: is ambiguous given the existing manualActivation flag on RNGestureHandler. It’s hard to tell whether this refers to “manual activation” vs “manual state changes via setGestureState”. Consider renaming this parameter/selector to something more specific (e.g. fromManualStateChange: or fromStateManager:) to avoid API confusion.

@m-bert what do you think?

I agree with @copilot , my first thought was fromManualStateChange, but second one is also ok.

Copilot · 2026-02-25T11:49:31Z

@m-bert I've opened a new pull request, #3996, to work on those changes. Once the pull request is ready, I'll request review from you.

…dler API (#3996) The `fromManual:` selector label was ambiguous — it could be confused with the existing `manualActivation` flag on `RNGestureHandler`. Rename it to `fromManualStateChange:` to clearly convey that this parameter tracks state changes triggered via `setGestureState` (the manual state manager path), not manual activation. - **`RNGestureHandler.h`** — updated all three method declarations - **`RNGestureHandler.mm`** — updated implementations and all call sites - **`RNGestureHandlerModule.mm`** — updated `setGestureState` call sites (the only places passing `YES`) - **All handler files** (`RNFlingHandler`, `RNHoverHandler`, `RNLongPressHandler`, `RNPanHandler`, `RNPinchHandler`, `RNRotationHandler`, `RNTapHandler`) — updated forwarding declarations and call sites  --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: m-bert <63123542+m-bert@users.noreply.github.com>

akwasniewski and others added 7 commits February 16, 2026 10:22

dont rely on reset

56727fe

xcode played me

468bf1b

go through begin

a89a631

eliminate recursion ios

68b0164

check against explicit value

149e469

Merge branch 'main' into @akwasniewski/ios-state-manager-dont-rely-on…

caefa77

…-reset

fix the other issue

8849fdd

akwasniewski requested a review from Copilot February 19, 2026 12:20

Copilot started reviewing on behalf of akwasniewski February 19, 2026 12:20 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

packages/react-native-gesture-handler/apple/RNGestureHandler.mm Outdated Show resolved Hide resolved

correct type

c7d67aa

akwasniewski requested review from j-piasecki and m-bert February 19, 2026 12:42

m-bert reviewed Feb 19, 2026

View reviewed changes

packages/react-native-gesture-handler/apple/RNGestureHandler.mm Outdated Show resolved Hide resolved

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m Outdated Show resolved Hide resolved

Base automatically changed from @akwasniewski/ios-state-manager-dont-rely-on-reset to main February 23, 2026 07:14

Merge branch 'main' into @akwasniewski/ios-fix-state-manager-begin

409601e

akwasniewski requested a review from Copilot February 23, 2026 07:37

j-piasecki reviewed Feb 23, 2026

View reviewed changes

Copilot started reviewing on behalf of akwasniewski February 23, 2026 07:38 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m Outdated Show resolved Hide resolved

packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m Outdated Show resolved Hide resolved

cleanup after merge

5f72e4b

akwasniewski requested a review from Copilot February 23, 2026 08:56

Copilot started reviewing on behalf of akwasniewski February 23, 2026 08:56 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

akwasniewski and others added 4 commits February 23, 2026 10:21

Update packages/react-native-gesture-handler/apple/Handlers/RNFlingHa…

4c920b5

…ndler.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rename to fromManual

0a7f0d7

fix self

8be794c

remove the fling override altogether

1246b9d

akwasniewski requested a review from Copilot February 24, 2026 09:45

Copilot started reviewing on behalf of akwasniewski February 24, 2026 09:45 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 25, 2026

[iOS] Rename fromManual: to fromManualStateChange: in gesture handler API #3996

Merged

		[_gestureHandler handleGesture:self fromReset:fromReset manualActivation:NO];
		}

	[_gestureHandler handleGesture:recognizer fromReset:NO manualActivation:NO];
	[self handleGesture:recognizer fromReset:NO manualActivation:NO];

Uh oh!

Conversation

akwasniewski commented Feb 19, 2026

Description

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

m-bert left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akwasniewski Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 25, 2026

Uh oh!

m-bert left a comment •

edited

Loading

akwasniewski Feb 23, 2026 •

edited

Loading