Skip to content

fix: OAuth 응답에 isRegistered 추가 #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsy1307 merged 1 commit into from
Mar 11, 2026
Merged

fix: OAuth 응답에 isRegistered 추가 #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/example/solidconnection/auth/dto/oauth/OAuthSignInResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
import com.example.solidconnection.auth.dto.SignInResult;

public record OAuthSignInResponse(
boolean isRegistered,
String accessToken) implements OAuthResponse {

public static OAuthSignInResponse from(SignInResult signInResult) {
return new OAuthSignInResponse(signInResult.accessToken());
return new OAuthSignInResponse(true, signInResult.accessToken());
}
}
2 changes: 2 additions & 0 deletions src/main/java/com/example/solidconnection/auth/dto/oauth/SignUpPrepareResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
package com.example.solidconnection.auth.dto.oauth;

public record SignUpPrepareResponse(
boolean isRegistered,
String nickname,
String email,
String profileImageUrl,
String signUpToken) implements OAuthResponse {

public static SignUpPrepareResponse of(OAuthUserInfoDto oAuthUserInfoDto, String signUpToken) {
return new SignUpPrepareResponse(
false,
oAuthUserInfoDto.getNickname(),
oAuthUserInfoDto.getEmail(),
oAuthUserInfoDto.getProfileImageUrl(),
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ void setUp() { // 실제 client 호출하지 않도록 mocking
assertThat(response).isInstanceOf(OAuthSignInResponse.class);
OAuthSignInResponse signInResponse = (OAuthSignInResponse) response;
assertAll(
() -> assertThat(signInResponse.isRegistered()).isTrue(),
() -> assertThat(signInResponse.accessToken()).isNotBlank(),
() -> assertThat(oAuthResult.refreshToken()).isNotBlank()
);
Expand All @@ -80,6 +81,7 @@ void setUp() { // 실제 client 호출하지 않도록 mocking
assertThat(response).isInstanceOf(SignUpPrepareResponse.class);
SignUpPrepareResponse signUpPrepareResponse = (SignUpPrepareResponse) response;
assertAll(
() -> assertThat(signUpPrepareResponse.isRegistered()).isFalse(),
() -> assertThat(signUpPrepareResponse.signUpToken()).isNotBlank(),
() -> assertThat(signUpPrepareResponse.email()).isEqualTo(email),
() -> assertThat(signUpPrepareResponse.profileImageUrl()).isEqualTo(profileImageUrl),
Expand Down
Loading