Skip to content

fix(web): unify default profile image across mentor and community#483

Merged
manNomi merged 1 commit intomainfrom
codex/mentor-default-profile-image
Mar 14, 2026
Merged

fix(web): unify default profile image across mentor and community#483
manNomi merged 1 commit intomainfrom
codex/mentor-default-profile-image

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Mar 14, 2026

Summary

  • add shared default profile image constant (/images/placeholder/profile64.svg)
  • update ProfileWithBadge to always use the shared default for missing/broken profile images
  • update community post/comment profile fallbacks to use the same shared default

Validation

  • pnpm --filter @solid-connect/web exec biome check src/constants/profile.ts src/components/ui/ProfileWithBadge.tsx src/app/community/[boardCode]/[postId]/CommentSection.tsx src/app/community/[boardCode]/[postId]/Content.tsx
  • pnpm --filter @solid-connect/web run typecheck
  • pre-commit hook: web ci:check
  • pre-push hook: web ci:check + web build

@vercel
Copy link

vercel bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Ready Ready Preview, Comment Mar 14, 2026 0:49am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Mar 14, 2026 0:49am

@github-actions github-actions bot added the web label Mar 14, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

Walkthrough

이번 변경 사항은 프로필 이미지의 기본값을 중앙 집중식 상수로 통합하는 리팩토링입니다. 여러 컴포넌트에 산재되어 있던 하드코딩된 경로 문자열을 제거하고, 새로운 상수를 통해 일관되게 관리하도록 개선했습니다.

변경 사항 목록:

  1. profile.ts 상수 파일 생성 — DEFAULT_PROFILE_IMAGE 상수 추가로 기본 프로필 이미지 경로 정의
  2. CommentSection.tsx 업데이트 — 하드코딩된 경로를 상수로 변경
  3. Content.tsx 업데이트 — 동일한 경로를 상수로 변경
  4. ProfileWithBadge.tsx 업데이트 — 조건부 렌더링 로직을 단순화하면서 상수 활용

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • wibaek
  • enunsnv
  • khwww
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR 설명이 작업 내용을 명확하게 설명하지만, 한국어 템플릿의 필수 섹션(관련 이슈, 특이 사항, 리뷰 요구사항)이 누락되어 있습니다. 한국어 PR 템플릿을 따라 관련 이슈 번호, 특이 사항, 리뷰 요구사항 섹션을 추가하여 작성해 주세요.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 핵심을 명확하게 요약하고 있습니다. 기본 프로필 이미지를 mentor와 community에서 통일하는 것이 주요 목표이며, 제목이 이를 정확히 반영합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/mentor-default-profile-image
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manNomi manNomi merged commit 4606204 into main Mar 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant