Skip to content

feat: S3 credential resolution via APOS_S3_SECRET or AWS default chain #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-nomad merged 3 commits into from
Mar 10, 2026
Merged

feat: S3 credential resolution via APOS_S3_SECRET or AWS default chain #256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0914ebc
feat: S3 credential resolution via APOS_S3_SECRET or AWS default chain
Mar 10, 2026
e77392b
fix(uploadfs): correctly resolve S3 https flag and credentials
Mar 10, 2026
a7a6056
fix(uploadfs): normalize S3 https env flag
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions website/modules/@apostrophecms/uploadfs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,29 @@
const { getEnv } = require('../../../utils/env');

const aposS3Secret = process.env.APOS_S3_SECRET;
const aposS3Https = getEnv('APOS_S3_HTTPS');

const uploadfsOptions = {
storage: 's3',
bucket: getEnv('APOS_S3_BUCKET'),
region: getEnv('APOS_S3_REGION'),
endpoint: getEnv('APOS_S3_ENDPOINT'),
style: getEnv('APOS_S3_STYLE'),
https: aposS3Https.toLowerCase() === 'true',
cdn: {
enabled: true,
url: getEnv('APOS_CDN_URL'),
},
};

if (aposS3Secret) {
uploadfsOptions.secret = aposS3Secret;
uploadfsOptions.key = getEnv('APOS_S3_KEY');
}

const res = {
options: {
uploadfs: {
storage: 's3',
// Get your credentials at aws.amazon.com
secret: getEnv('APOS_S3_SECRET'),
key: getEnv('APOS_S3_KEY'),
// Bucket name created on aws.amazon.com
bucket: getEnv('APOS_S3_BUCKET'),
// Region name for endpoint
region: getEnv('APOS_S3_REGION'),
endpoint: getEnv('APOS_S3_ENDPOINT'),
style: getEnv('APOS_S3_STYLE'),
https: getEnv('APOS_S3_HTTPS'),
cdn: {
enabled: true,
url: getEnv('APOS_CDN_URL'),
},
},
uploadfs: uploadfsOptions,
},
};

Expand Down
Loading