Open
Conversation
mpetrunic
reviewed
Feb 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds validation for Lighter order values against configured confirmation buckets to ensure orders are within acceptable limits. The implementation follows the same pattern used in EVM chains for order value validation.
Changes:
- Added configuration for USD value buckets and their corresponding confirmation requirements
- Implemented order size validation in the Lighter message handler
- Added test coverage for invalid order values that exceed bucket limits
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| chains/lighter/config.go | Adds ConfirmationsByValue map to LighterConfig and populates it from solver configuration |
| chains/lighter/config_test.go | Adds test case validating confirmation bucket configuration |
| chains/lighter/message/lighter.go | Adds verifyOrderSize function and integrates it into withdrawal verification flow |
| chains/lighter/message/lighter_test.go | Adds test for invalid order value validation and fixes test setup to include confirmations; corrects InvalidAsset test to use proper transaction type |
| app/app.go | Passes ConfirmationsByValue from config to LighterMessageHandler constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpetrunic
approved these changes
Feb 12, 2026
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue Or Context
Closes: #141
How Has This Been Tested? Testing details.
Types of changes
Checklist: