adds an option to not close response synchronously#457
Open
sebtoun wants to merge 1 commit intosta:masterfrom
Open
adds an option to not close response synchronously#457sebtoun wants to merge 1 commit intosta:masterfrom
sebtoun wants to merge 1 commit intosta:masterfrom
Conversation
In Unity it is a common pattern to execute a task on the Unity main thread before sending a response. The added option prevent the processRequest method to always call HttpListenerResponse.Close method. It is then the responsibility of the event handler delegate to call this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Unity it is a common pattern to execute a task on the Unity main thread
before sending a response. The added option prevents the processRequest
method to always call HttpListenerResponse.Close method after the event
handler delegate has return. It is then the responsibility of the event handler
delegate to call this method.