Conversation
relates to STACKITCLI-307 and #1214
Fixed tests and linter relates to STACKITCLI-307 and #1214
relates to STACKITCLI-307 and #1214 tests added network ids included in list of project NICs
| } | ||
|
|
||
| // Truncate output | ||
| items := *resp.Items |
There was a problem hiding this comment.
Potential nil pointer dereference, take care of it please
There was a problem hiding this comment.
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| if err != nil { | ||
| projectLabel = model.ProjectId | ||
| } | ||
| params.Printer.Outputf("No network interfaces found for project %q\n", projectLabel) |
There was a problem hiding this comment.
Same as in your other PR. This belongs into outputResult, else you will have invalid JSON/YAML output here.
| networkLabel = *model.NetworkId | ||
| } | ||
| params.Printer.Info("No network interfaces found for network %q\n", networkLabel) | ||
| params.Printer.Outputf("No network interfaces found for network %q\n", networkLabel) |
There was a problem hiding this comment.
invalid JSON/YAML output, see comment above
| args: args{}, | ||
| wantErr: false, | ||
| }, | ||
| { |
There was a problem hiding this comment.
can we have some more test-cases for the output result stuff please?
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
2 participants
Description
relates to STACKITCLI-307 and #1214
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)