This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Open
Conversation
…esponse types are different even in the V1 version)
friedger
suggested changes
Sep 9, 2021
Contributor
friedger
left a comment
friedger
left a comment
There was a problem hiding this comment.
Could you please rebase the PR. This contains the changes from the last pr as well.
What about the DID method? Do you want to adapt the new specification?
|
|
||
| if (didType == "btc-addr") { | ||
| return did.split(':')[2] | ||
| }else if (didType == "stx-addr") { |
Contributor
There was a problem hiding this comment.
We now have a proper did specification for stacks 2.0. https://github.com/jolocom/stacks.js/blob/feat/add_did_resolver_package/packages/did-resolver/docs/DID_Method_Spec.md
Contributor
Author
There was a problem hiding this comment.
I did a more generic version, and updated the validation since according to the documentation the following
did:stack:v0:15gxXgJyT5tM5A4Cbx99nwccynHYsBouzr-3, is correct and can existe a multiple of different transactions, names, and namespaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.