feat: add possibility to write the filename per editor

[dimaslz]

Hello @stevebauman here the PR about my suggestion #29

Take a look at how it looks:

With one file:

With more than one file

Let me know if I can improve something in code or UI.

UPDATE: update with new UI and rebase with master

[netlify]

✔️ Deploy Preview for festive-hermann-8f687a ready!

🔨 Explore the source changes: 2c22446

🔍 Inspect the deploy log: https://app.netlify.com/sites/festive-hermann-8f687a/deploys/61e9d4d103cded0007de995e

😎 Browse the preview: https://deploy-preview-52--festive-hermann-8f687a.netlify.app

[stevebauman]

This is so cool @dimaslz! Nice work! 🎉

I'll review this early tomorrow, but I love this idea and the look of it 👍

[stevebauman]

Hmm -- when I add a new editor and start typing into the file name field, nothing appears on the preview window until I refresh?

[dimaslz]

Hello, @stevebauman I rebased and updated the PR, I think now is fixed. I missed the initial value.

[stevebauman]

Thanks @dimaslz! Could we have these inputs only show when we have 2 or more editors? I don’t think we should have them displayed when there’s only one editor (we can use the title field for that).

Let me know your thoughts!

[dimaslz]

Thanks @dimaslz! Could we have these inputs only show when we have 2 or more editors? I don’t think we should have them displayed when there’s only one editor (we can use the title field for that).

Let me know your thoughts!

Mmmm... I think make sense. I will take a look.

[dimaslz]

Hello @stevebauman, sorry for my delay.

Take a look ;)

[stevebauman]

Instead of a separate prop for allow-filename, can we use a ternary condition to simply pass in null in the filename prop? For example:

<Editor
  :filename="editors.length > 1 ? editor.filename : null"
/>

[dimaslz]

Ok, I remember why. If I do not use allow-filename, I don't know when I can allow writing the filename or not. For example, inside Editor.vue in the v-if="allowFilename", we need to know how much Editors are using to allow set the filename or not. With this :filename="editors.length > 1 ? editor.filename : null", the filename always is allowed to set but, when just exists one Editor, the filename field is visible, but not visible in the render. Do you know what I mean?

[dimaslz]

Maybe I can do something like canSetFilename

[stevebauman]

Can we add an additional clause here to the if statement so the <div> isn't rendered if the filename is empty? Ex:

<div
  v-if="filenames.length > 1 && filenames[index]"
>

Once these two changes are made I'll merge this in 👍

Thanks for your time and work! ❤️

[bdsoha]

@dimaslz @stevebauman Any updates on this feature?

[crock]

Bumping this. looks like @stevebauman forgot to merge OP's PR haha