-
Notifications
You must be signed in to change notification settings - Fork 648
feat: adding terminate attribute for after-model-call-event hooks #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/strands review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
poshinchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there's conflict, could you resolve it?
b8baca0 to
226d67f
Compare
226d67f to
ac678a9
Compare
|
Per discussion, we want to instead try to expand the concept of interrupt to be used in cases like this where the user stops the agent loop from a hook lifecycle event. The new behaviors to support are:
|
Description
Supporting agent event loop termination via after-model-call-event hooks
Type of Change
Bug fix
[x] New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.