Update exploring.clj#13
Open
ssisksl77 wants to merge 1 commit intostuarthalloway:masterfrom
ssisksl77:master
Open
Update exploring.clj#13ssisksl77 wants to merge 1 commit intostuarthalloway:masterfrom ssisksl77:master
ssisksl77 wants to merge 1 commit intostuarthalloway:masterfrom
ssisksl77:master
Conversation
line56
(defn index-filter [pred coll]
(when pred
(for [[idx elt] (indexed coll) :when (pred elt)] idx)))
I think that 'when' is not necessary. and I've changed like this.
(defn index-filter [pred coll]
(for [[idx elt] (indexed coll) :when (pred elt)] idx))
please check this out.
If I am wrong. I'd be grateful that If you send me an email.
ssisksl77@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line56
(defn index-filter [pred coll](when pred
%28for [[idx elt] %28indexed coll%29 :when %28pred elt%29] idx%29))
I think that 'when' is not necessary. and I've changed like this.
(defn index-filter [pred coll](for [[idx elt] %28indexed coll%29 :when %28pred elt%29] idx))
please check this out.
If I am wrong. I'd be grateful that If you send me an email.
ssisksl77@gmail.com