deploy: don't check for private IPs during dns check#4741
Open
pborzenkov wants to merge 1 commit intomasterfrom
Open
deploy: don't check for private IPs during dns check#4741pborzenkov wants to merge 1 commit intomasterfrom
pborzenkov wants to merge 1 commit intomasterfrom
Conversation
Machines API returns both public and private (Flycast) allocated addresses. Filter out the private ones from the check as our public DNS will never return them.
Member
|
Oh, I faced the same issue last week and fixed with 0632ef5. Does it look good to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machines API returns both public and private (Flycast) allocated
addresses. Filter out the private ones from the check as our public DNS
will never return them.