tokenizer header: add multi-header support#39
Open
prashanthpai wants to merge 2 commits intosuperfly:mainfrom
Open
tokenizer header: add multi-header support#39prashanthpai wants to merge 2 commits intosuperfly:mainfrom
prashanthpai wants to merge 2 commits intosuperfly:mainfrom
Conversation
Signed-off-by: Prashanth Pai <411294+prashanthpai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows customization of which headers are checked for sealed secrets via build-time ldflags or
TOKENIZER_HEADERSenv var, following the same pattern asFilteredHeaders.We have many instances where we can't modify the source of the traffic to inject the hard-coded
Proxy-Tokenizerheader. To route such calls, all we need is for the source to respecthttp_proxyenv vars which many tools (like curl, git etc) do support.This is a non-breaking change which continues to expect
Proxy-Tokenizeras the default header unless explicitly overridden.P.S: The unit tests are AI generated.