Skip to content

fix: reduce stop hook API timeout from 10m to 90s #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greynewell merged 2 commits into from
Mar 9, 2026
Merged

fix: reduce stop hook API timeout from 10m to 90s #567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01464b
fix: reduce stop hook API timeout from 10m to 90s to prevent session …
greynewell Mar 9, 2026
dc468ea
fix: fail fast on API connection errors instead of retrying for 10 mi…
greynewell Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions internal/api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,13 +371,15 @@ func (c *Client) pollJob(

resp, err := c.httpClient.Do(req)
if err != nil {
c.logFn("[warn] poll attempt %d (%s): request error (will retry): %v", attempt+1, endpoint, err)
select {
case <-ctx.Done():
return ctxDeadlineErr(ctx)
case <-c.afterFn(10 * time.Second):
}
continue
// Connection-level errors (DNS failure, connection refused, network
// unreachable) mean the API is down. Retrying won't help and would
// block the caller — typically the Claude Code Stop hook — for the
// full context duration. Return immediately so the hook can exit
// gracefully rather than hanging until the context deadline fires.
// This is distinct from HTTP-level errors (5xx, rate limits) and
// job-processing delays ("pending"/"processing"), which do warrant
// polling retries.
return fmt.Errorf("API unreachable: %w", err)
}
respBody, readErr := io.ReadAll(io.LimitReader(resp.Body, maxResponseSize))
resp.Body.Close()
Expand Down