Fix local test failure in GenericsWrapJavaTests#588
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Mar 6, 2026
Merged
Conversation
Collaborator
|
Happy to take this |
ktoso
approved these changes
Mar 6, 2026
Contributor
Author
|
I've been ignoring this every time. Thanks for accpeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my local,
test_wrapJava_genericMethodTypeErasure_ofNullableOptional_staticMethodsfails, even though it appears to pass in CI. This suggests the failure might be environment-specific.In my research, the presence of the closing brace
}seems to be the cause of the mismatch.While the exact reason for this discrepancy across environments is unclear, but the brace is not critical to the intent of this test.
Therefore, I want to delete this.