Select correct Noto Sans CJK font variant in stargraphic writer#4
Open
johnnyshields wants to merge 1 commit intomainfrom
Open
Select correct Noto Sans CJK font variant in stargraphic writer#4johnnyshields wants to merge 1 commit intomainfrom
johnnyshields wants to merge 1 commit intomainfrom
Conversation
Use the profile's cjk_encoding to select the language-appropriate Noto Sans variant (JP, SC, TC, KR) for Pango text rasterization. This ensures correct glyph rendering for Han-unified codepoints where the same Unicode character has different visual forms per locale. Replaces the old fc-list-based font detection singleton with a locale-driven lookup from the existing CJK encoding configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cjk_encodingto the correct Noto Sans language variant (Noto Sans JP,Noto Sans SC,Noto Sans TC,Noto Sans KR) for Pango text rasterization in the stargraphic writer.fc-list-based singleton font detection with a locale-driven lookup, reusing the existing CJK encoding configuration.Test plan
cjk_encoding: :jausesNoto Sans JPcjk_encoding: :zhusesNoto Sans SCcjk_encoding: 'zh-TW'usesNoto Sans TCcjk_encoding: :kousesNoto Sans KRNoto Sanswhen no CJK encoding is set🤖 Generated with Claude Code