Upgrade SDK to 17.0.1 (Android) & 6.13.0 (iOS)#4
Open
mobilearmor wants to merge 1 commit intomasterfrom
Open
Conversation
Collaborator
martinzigrai
left a comment
There was a problem hiding this comment.
Looks good to me! Please address the comments below.
| public static native void raspExecutionFinished(); | ||
|
|
||
|
|
||
| public static class AppRaspExecutionState extends ThreatListener.RaspExecutionState { |
Collaborator
There was a problem hiding this comment.
Would you please change it to a private static class?
| * Sends a RASP status notification from native code to Unreal Engine. | ||
| * | ||
| * This method is called by the native FreeRASP library (Talsec) during the RASP execution | ||
| * It broadcasts the RASP status through the OnRASPStatusDetected delegate on the game thread. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * It broadcasts the RASP status through the OnRASPStatusDetected delegate on the game thread. | |
| * It broadcasts the RASP status through the OnRASPExecutionStatus delegate on the game thread. |
| // this is used for notifying the native code that the RASP execution has finished | ||
| public static native void raspExecutionFinished(); | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Please remove this empty line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
Here are the high level changes
SDK Side Changes
Developer Side Changes
The old callback stays the same