fix: broken testing environment start due to changes in startTemporalServer#726
Open
mtorromeo wants to merge 1 commit intotemporalio:masterfrom
Open
fix: broken testing environment start due to changes in startTemporalServer#726mtorromeo wants to merge 1 commit intotemporalio:masterfrom
mtorromeo wants to merge 1 commit intotemporalio:masterfrom
Conversation
|
@mtorromeo is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Also, I didn't want to remove any funcionality in this PR but I think it would be best to just not accept string at all for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Changed
Temporal\Testing\Environment::startRoadRunnerto accept array for$rrCommandand to use it also in its check loop.Why?
There are two new issues in version 2.17 of the testing environment that were not present in 2.15.
In
Temporal\Testing\Environmentthestartmethod only acceptsarray|nullfor its$rrCommandparameter, but this parameter is passed as-is tostartRoadRunner, which instead only acceptsstring|null, making this effectively only work when$rrCommand === null.startRoadRunnercompletely disregards the passed-in$rrCommandfor executing theworkerscommand when checking the status of the server. This may work sometimes but depending on the specific custom command used it's likely wrong.I kind of fixed this by replacing the
servecommand withworkersbut I don't particularly like this either.While fixing this I changed the while loop that tests the server to quickly exit the loop if the command is not running anymore, instead of waiting for the timeout, and I did the same in
startTemporalServer.Checklist