refactor(workflow): remove minimizeEventView store#3182
Open
rossnelson wants to merge 1 commit intomainfrom
Open
refactor(workflow): remove minimizeEventView store#3182rossnelson wants to merge 1 commit intomainfrom
rossnelson wants to merge 1 commit intomainfrom
Conversation
The minimizeEventView store is no longer needed after removing the
expand/minimize toggle from the Event History toolbar. This removes
the store definition, all references, and cleans up the unused
twMerge import and {#key} block that depended on it.
rossnelson
requested review from
a team,
Alex-Tideman and
rossedfort
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimizeEventViewpersist store fromevent-view.ts— no longer needed after removing the expand/minimize toggle in fix(workflow): remove expand/minimize button from Event History #3181workflow-history-layout.svelte(sticky toolbar conditional, EventTypeFilterminimizedprop){#key $minimizeEventView}wrapper ininput-and-results-payload.sveltethat forced re-renders on toggletwMergeimportTest plan
{#key}wrapper