docs: document fee sponsorship signing hash behavior #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brendanjryan
force-pushed
the
docs/fee-sponsorship-signing-behavior
branch
from
52c0ee7 to
69f776d
Compare
brendanjryan
force-pushed
the
docs/fee-sponsorship-signing-behavior
branch
from
69f776d to
442e7c6
Compare
Adds documentation explaining that when building sponsored transactions, the sender must indicate sponsorship BEFORE signing because the signing hash differs: - Sponsored: fee_token omitted from signing payload, 0x00 marker used - Non-sponsored: fee_token included in signing payload This was raised as feedback from an external integration partner who discovered this behavior during testing. Changes: - Added warning callout in Go SDK docs - Added 'Signing Hash Behavior' section in sponsor-user-fees guide
brendanjryan
force-pushed
the
docs/fee-sponsorship-signing-behavior
branch
from
442e7c6 to
d9317ac
Compare
- Add build step after typecheck in CI to catch build failures before deploy - Change checkDeadlinks to 'warn' (TIP-1011 has dead link in tempo repo)
brendanjryan
force-pushed
the
docs/fee-sponsorship-signing-behavior
branch
from
33bc4b3 to
a09d0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documents an important design choice in fee sponsorship: the sender must indicate sponsorship before signing because the signing hash differs based on whether a transaction will be sponsored.