Performance improvement for compute_enpt2 and add_hci#113
Merged
msricher merged 1 commit intotheochem:masterfrom Jan 5, 2026
Merged
Performance improvement for compute_enpt2 and add_hci#113msricher merged 1 commit intotheochem:masterfrom
msricher merged 1 commit intotheochem:masterfrom
Conversation
Member
|
Thanks @peter-reinholdt . I assigned Michelle to look at this. You should be aware that we are doing a major rewrite of PyCI right now, so we are in "maintenance mode" on the current public version of PyCI right now. That said, to my naive eyes, this should be easy to transfer over to the new back end. |
Collaborator
|
I will definitely check this out in the next few days when I have a bit more time, and merge it. Just confirming that I've seen it for now. Thanks! |
msricher
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some work can be avoided when searching for determinants in the compute_enpt2 and add_hci routines.
Rewrite the criterion
as
The value of the Hamiltonian matrix element is independent of what happens with, e.g.,
excite_det- so sometimes work can be skipped.The performance improvement is system-dependent, but here is an example for water/cc-pVDZ.
Timings are in seconds, single thread. The benefit is most substantial when the majority of the determinants are rejected; when most determinants are accepted, there is almost no benefit.