Skip to content

Add NameRedaction and PasswordRedaction classes with usage examples in README.md.#3

Merged
gustavofreze merged 1 commit intomainfrom
feature/develop
Feb 25, 2026
Merged

Add NameRedaction and PasswordRedaction classes with usage examples in README.md.#3
gustavofreze merged 1 commit intomainfrom
feature/develop

Conversation

@gustavofreze
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 25, 2026 03:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new redaction classes (PasswordRedaction and NameRedaction) to the structured logger library, providing enhanced security capabilities for logging sensitive data. The changes follow established codebase patterns and maintain consistency with existing redaction implementations.

Changes:

  • Adds PasswordRedaction class that fully masks password values with asterisks
  • Adds NameRedaction class that preserves the first N characters (default: 2) and masks the rest
  • Includes comprehensive test coverage with 10 new test cases following BDD-style conventions
  • Updates README.md with usage examples and documentation for both new redaction types

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Redactions/PasswordRedaction.php New redaction class implementing full value masking for password fields
src/Redactions/NameRedaction.php New redaction class implementing prefix-preserving masking for name fields
tests/StructuredLoggerTest.php Adds comprehensive test coverage (10 tests) for both new redaction classes and updates existing multi-redaction test
README.md Adds documentation sections with usage examples for PasswordRedaction and NameRedaction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavofreze gustavofreze merged commit f4e8eb8 into main Feb 25, 2026
10 checks passed
@gustavofreze gustavofreze deleted the feature/develop branch February 25, 2026 04:03
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13212bb921

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants