Expose list peers and channels#3
Closed
jurvis wants to merge 3 commits intotnull:2022-09-start-uniffifrom
Closed
Conversation
jurvis
force-pushed
the
jurvis/2022-09-start-uniffi/expose-list-peers-and-channels
branch
2 times, most recently
from
5f70206 to
95f3789
Compare
tnull
force-pushed
the
2022-09-start-uniffi
branch
4 times, most recently
from
a06c67e to
a491ede
Compare
jurvis
force-pushed
the
jurvis/2022-09-start-uniffi/expose-list-peers-and-channels
branch
3 times, most recently
from
cd804b2 to
d51de5c
Compare
tnull
reviewed
Mar 31, 2023
Owner
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Awesome, thanks for taking this on!
As discussed offline, this approach is fine for ChannelDetails, but for list_peers we probably want to add a new struct that also exposes the information from PeerManager to include whether we're actually connected to them.
As this will grow a tiny bit more, do you mind closing this and reopening the PR against upstream, based on lightningdevkit#25?
tnull
force-pushed
the
2022-09-start-uniffi
branch
from
38aac93 to
c04f28f
Compare
Author
|
Yep! Sounds good to me -- will make the updates and change the PR's base branch 😄 |
jurvis
force-pushed
the
jurvis/2022-09-start-uniffi/expose-list-peers-and-channels
branch
from
d51de5c to
542f71f
Compare
Author
|
closing in favor of lightningdevkit#56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if we want to expose a shorter list of fields to users/anything in documentation needs tweaking here. I copied/rephrased mostly from
rust-lightningto be more relevant to anLdkNodeuser.