Skip to content

PM-4070 Change completeness text for admin #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 3 commits into from
Mar 3, 2026
Merged

PM-4070 Change completeness text for admin #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d6613a
PM-4070 Change completeness text for admin
himaniraghav3 Mar 3, 2026
b52a4b7
Fix admin view
himaniraghav3 Mar 3, 2026
545a051
fix error
himaniraghav3 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/apps/profiles/src/member-profile/page-layout/ProfilePageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,11 @@ const ProfilePageLayout: FC<ProfilePageLayoutProps> = (props: ProfilePageLayoutP
</div>
<div className={styles.profileInfoRight}>
{canSeeProfileCompleteness && (
<ProfileCompleteness profile={props.profile} authProfile={props.authProfile} />
<ProfileCompleteness
profile={props.profile}
authProfile={props.authProfile}
isAdminOrTM={isAdminOrTM}
/>
)}
<div className={styles.sectionWrap}>
<div className={styles.skillsWrap}>
Expand Down
40 changes: 27 additions & 13 deletions src/apps/profiles/src/member-profile/profile-completeness/ProfileCompleteness.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import styles from './ProfileCompleteness.module.scss'
interface ProfileCompletenessProps {
profile: UserProfile
authProfile: UserProfile | undefined
isAdminOrTM?: boolean
Copy link

@github-actions github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing isAdminOrTM from a required to an optional prop could lead to potential issues if the component logic assumes it is always defined. Ensure that the component handles the case where isAdminOrTM is undefined appropriately, especially in conditional rendering.

}

const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
Expand Down Expand Up @@ -42,19 +43,32 @@ const ProfileCompleteness: FC<ProfileCompletenessProps> = props => {
<div className={styles.wrap}>
<strong>Profile: </strong>
{`${completed}% Complete`}
<div>
<small>
Only
{' '}
{incompleteEntries}
{' '}
left to fill. Please add
{' '}
{count === 1 ? 'it' : 'them'}
{' '}
to make your profile more discoverable.
</small>
</div>
{!props.isAdminOrTM
&& (
<div>
<small>
Only
{' '}
{incompleteEntries}
{' '}
left to fill. Please add
{' '}
{count === 1 ? 'it' : 'them'}
{' '}
to make your profile more discoverable.
</small>
</div>
)}
{props.isAdminOrTM
&& (
<div>
<small>
{incompleteEntries}
{' '}
left to fill by the member.
</small>
</div>
)}
</div>
)
}
Expand Down
Loading