Use deny policies rather than conditions to reject insecure access#21
Merged
RealOrangeOne merged 2 commits intomasterfrom Jan 28, 2026
Merged
Use deny policies rather than conditions to reject insecure access#21RealOrangeOne merged 2 commits intomasterfrom
RealOrangeOne merged 2 commits intomasterfrom
Conversation
RealOrangeOne
force-pushed
the
harden-https-requirement
branch
from
a27fb9a to
d6ee06a
Compare
Member
|
Looks good to me! |
tomusher
approved these changes
Jan 5, 2026
S3 already only accepts TLS 1.2+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some issues with the previous format, where the condition would be applied strangely and somewhat selectively. I couldn't reproduce them, but doing the policies this way is probably better.
This uses explicit "Deny" policies, which should be easier to understand, since they're applied before any other policies, making them simpler to manage.
Policies taken from https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/f90d8a385e4c70afd048e8997dcccf125b362236/main.tf#L965 and https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/f90d8a385e4c70afd048e8997dcccf125b362236/main.tf#L934