Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis PR removes TX3 transaction construction features and refactors transaction invocation to use TII (Transaction Invocation Interface). Dependencies are updated: bech32 upgraded, tx3-sdk switched to local path-based dependency, and numerous new crates added. The construct module is entirely eliminated, and invoke/resolve commands are refactored with renamed arguments (tii_file, args_json, etc.). Bech32 encoding/decoding is migrated to newer API. Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI Command<br/>(invoke/resolve)
participant TII as TII Protocol<br/>(Invocation)
participant Args as Argument<br/>Resolution
participant Provider as Provider
participant Result as TxEnvelope
rect rgb(230, 245, 250)
Note over CLI,Result: New Invocation-based Workflow
end
CLI->>TII: prepare_invocation(tii_file, tx_template)
activate TII
TII->>TII: Load protocol from file
TII-->>CLI: Return mutable Invocation
deactivate TII
CLI->>Args: define_args(invocation, args_json/file)
activate Args
Args->>Args: Resolve argument types from<br/>invocation.define_params()
Args->>Args: Load from JSON/file or<br/>interactive inquiry
Args-->>CLI: Return HashMap<String, ArgValue>
deactivate Args
CLI->>TII: invocation.set_args(args)
activate TII
TII->>TII: Store arguments in invocation
deactivate TII
CLI->>Provider: resolve_tx(invocation, provider)
activate Provider
Provider->>TII: Convert via<br/>invocation.into_trp_request()
TII-->>Provider: Return TxEnvelope
Provider-->>Result: Return signed/resolved TX
deactivate Provider
Result-->>CLI: TxEnvelope (ready for submit)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Removed Features
Updates
Chores
✏️ Tip: You can customize this high-level summary in your review settings.