feature: Allow to customize reqwest client builder#73
Merged
RoDmitry merged 4 commits intotypesense:mainfrom Mar 6, 2026
Merged
feature: Allow to customize reqwest client builder#73RoDmitry merged 4 commits intotypesense:mainfrom
RoDmitry merged 4 commits intotypesense:mainfrom
Conversation
1 task
Contributor
Author
|
@RoDmitry will you be able to take a look at the PR? |
RoDmitry
requested changes
Mar 5, 2026
typesense/tests/client/http_builder_test/http_builder_tls_test.rs
Outdated
Show resolved
Hide resolved
RoDmitry
force-pushed
the
feature/reqwest-client-builder
branch
from
5c52136 to
16a3793
Compare
RoDmitry
force-pushed
the
feature/reqwest-client-builder
branch
from
ffeb13a to
6d67c0e
Compare
Collaborator
|
@luis-araujo-dev review my changes, and tell me if it's ready to merge. |
Contributor
Author
|
The changes look good! Happy to merge the PR as is! |
RoDmitry
approved these changes
Mar 6, 2026
Collaborator
|
Thank you! I've liked the idea for a reverse compatibility with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
After taking a look into #67, I created this PR with the same goal, following maintainers guidance.
This PR allows to customize the reqwest client builder by each node, by using a closure.
I left the default connection timeout value around for non-WASM, but used
connection_timeoutinstead oftimeoutsince it looked to be what's desired and expected.PR Checklist