fix: force-track H5P DragText and Dialogcards dist/ files#71
Merged
fanxiaotuGod merged 1 commit intomainfrom Mar 3, 2026
Merged
fix: force-track H5P DragText and Dialogcards dist/ files#71fanxiaotuGod merged 1 commit intomainfrom
fanxiaotuGod merged 1 commit intomainfrom
Conversation
Root cause: .gitignore contains `dist/` which excluded the webpack build output for H5P.DragText-1.10 and H5P.Dialogcards-1.9. These two libraries store their compiled JS/CSS in dist/ unlike other H5P libraries that use js/ or scripts/. The files existed locally but were never deployed to staging, causing "Library not loaded" errors. Also removes diagnostic logging added during troubleshooting and serves library files through /api/create/h5p-preview/libs/* route instead of a separate /h5p-libs static route (no nginx config needed). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: .gitignore contains
dist/which excluded the webpack build output for H5P.DragText-1.10 and H5P.Dialogcards-1.9. These two libraries store their compiled JS/CSS in dist/ unlike other H5P libraries that use js/ or scripts/. The files existed locally but were never deployed to staging, causing "Library not loaded" errors.Also removes diagnostic logging added during troubleshooting and serves library files through /api/create/h5p-preview/libs/* route instead of a separate /h5p-libs static route (no nginx config needed).