Skip to content

fix(Bootinfo): update GUIDs shown.#2572

Open
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:fix(Bootinfo)-update-boot-info-page
Open

fix(Bootinfo): update GUIDs shown.#2572
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:fix(Bootinfo)-update-boot-info-page

Conversation

@SimonFair
Copy link
Contributor

@SimonFair SimonFair commented Mar 16, 2026

Summary by CodeRabbit

  • New Features
    • Boot Info now dynamically displays Active GUID and type indicators based on available GUID sources.
    • Shows "No GUID source found" when GUID is unavailable.
    • Displays GUID type (TPM or Flash) based on source detection.
    • TPM Licensing and TPM GUID sections now conditionally appear.

@SimonFair SimonFair marked this pull request as ready for review March 16, 2026 11:39
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Walkthrough

Modified BootInfo.page to replace static GUID display with dynamic conditional rendering. Introduced tpmEnabled flag to control visibility of TPM-specific sections based on flashGUID and tpmGUID presence. Active GUID now displays dynamically with type indicators.

Changes

Cohort / File(s) Summary
Dynamic GUID Display & TPM Conditional Rendering
emhttp/plugins/dynamix/BootInfo.page
Replaced static flashVendor/flashProduct/flashGUID display with dynamic Active GUID and GUID Type labels. Added tpmEnabled flag to conditionally show TPM Licensing and TPM GUID blocks. Active GUID shows "No GUID source found" when flashGUID is absent; GUID Type shows "TPM" for GUIDs starting with "03-", otherwise "Flash".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A GUID was once frozen in place,
Now dynamic with conditional grace!
When TPM appears with its "03-" way,
New sections reveal what before was hidden away. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(Bootinfo): update GUIDs shown' directly relates to the main change: updating the dynamic display of GUIDs with conditional rendering based on flashGUID presence and type indicators.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@github-actions
Copy link

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.03.16.1139
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2572/webgui-pr-2572.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/BootInfo.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2572, or run:

plugin remove webgui-pr-2572

🤖 This comment is automatically generated and will be updated with each new push to this PR.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@emhttp/plugins/dynamix/BootInfo.page`:
- Line 17: The TPM detection logic for $tpmEnabled is inverted: update the
condition that checks $var['flashGUID'] so it tests for a leading '03-' (use
strpos($var['flashGUID'], '03-') === 0) and drop the redundant ternary ? true :
false; i.e., set $tpmEnabled based on ( !empty($var['flashGUID']) && strpos(...
) === 0 && !empty($var['tpmGUID']) ) to ensure TPM-based GUIDs enable the TPM
Licensing section.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bf25ed1-08da-4919-afa5-7880f91a7b17

📥 Commits

Reviewing files that changed from the base of the PR and between e9b1f01 and 372f429.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/BootInfo.page

@SimonFair SimonFair added the 7.3 label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant