fix: avoid using saveState to detect unclean buildkitd shutdown#69
Open
haines wants to merge 1 commit intouseblacksmith:mainfrom
Open
fix: avoid using saveState to detect unclean buildkitd shutdown#69haines wants to merge 1 commit intouseblacksmith:mainfrom
saveState to detect unclean buildkitd shutdown#69haines wants to merge 1 commit intouseblacksmith:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
haines
added a commit
to cerbos/setup-docker-builder
that referenced
this pull request
Mar 13, 2026
useblacksmith#69 Signed-off-by: Andrew Haines <haines@cerbos.dev>
7739b7f to
7a0caad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #68
Note
Medium Risk
Moderate risk because it changes cleanup decision logic that gates sticky-disk commits; incorrect shutdown classification could skip commits or commit after a bad shutdown.
Overview
Cleanup now treats
shutdownBuildkitd()as returning whether shutdown was graceful vs forced, and logs the outcome accordingly.Sticky-disk commit gating is updated to skip commits whenever BuildKit did not shut down cleanly (including crashes/missing process), and the old
sigkillUsedstate flag is removed fromstate-helper/shutdown flow.Written by Cursor Bugbot for commit 7a0caad. This will update automatically on new commits. Configure here.