Skip to content

fix: avoid using saveState to detect unclean buildkitd shutdown#69

Open
haines wants to merge 1 commit intouseblacksmith:mainfrom
haines:fix-buildkitd-shutdown-detection
Open

fix: avoid using saveState to detect unclean buildkitd shutdown#69
haines wants to merge 1 commit intouseblacksmith:mainfrom
haines:fix-buildkitd-shutdown-detection

Conversation

@haines
Copy link

@haines haines commented Mar 13, 2026

Fixes #68


Note

Medium Risk
Moderate risk because it changes cleanup decision logic that gates sticky-disk commits; incorrect shutdown classification could skip commits or commit after a bad shutdown.

Overview
Cleanup now treats shutdownBuildkitd() as returning whether shutdown was graceful vs forced, and logs the outcome accordingly.

Sticky-disk commit gating is updated to skip commits whenever BuildKit did not shut down cleanly (including crashes/missing process), and the old sigkillUsed state flag is removed from state-helper/shutdown flow.

Written by Cursor Bugbot for commit 7a0caad. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

haines added a commit to cerbos/setup-docker-builder that referenced this pull request Mar 13, 2026
useblacksmith#69

Signed-off-by: Andrew Haines <haines@cerbos.dev>
@haines haines force-pushed the fix-buildkitd-shutdown-detection branch from 7739b7f to 7a0caad Compare March 13, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contradictory output on shutdown; sticky disk committed even after forceful termination of buildkitd

1 participant