Skip to content

fix: deployment download bugs and range clamping in Appwrite source #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 6 commits into from
Feb 25, 2026
Merged

fix: deployment download bugs and range clamping in Appwrite source #152

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8260df
fix: remove strtolower on resources to preserve camelCase
premtsd-code Feb 24, 2026
987d11c
fix: use camelCase for multi-word resource type values
premtsd-code Feb 24, 2026
8b1b42d
fix: deployment download bugs in exportDeploymentData and exportSiteD…
premtsd-code Feb 25, 2026
261bc05
Revert "fix: use camelCase for multi-word resource type values"
premtsd-code Feb 25, 2026
3190013
Revert "fix: remove strtolower on resources to preserve camelCase"
premtsd-code Feb 25, 2026
134efdc
fix: use consistent end >= fileSize range clamping
premtsd-code Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/Migration/Sources/Appwrite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,7 +1471,7 @@ private function exportFileData(File $file): void
// Get the file size
$fileSize = $file->getSize();

if ($end > $fileSize) {
if ($end >= $fileSize) {
$end = $fileSize - 1;
}

Expand All @@ -1495,7 +1495,7 @@ private function exportFileData(File $file): void
$start += Transfer::STORAGE_MAX_CHUNK_SIZE;
$end += Transfer::STORAGE_MAX_CHUNK_SIZE;

if ($end > $fileSize) {
if ($end >= $fileSize) {
$end = $fileSize - 1;
}
}
Expand Down Expand Up @@ -1704,8 +1704,8 @@ private function exportDeploymentData(Func $func, array $deployment): void
$responseHeaders
);

// Content-Length header was missing, file is less than max buffer size.
if (!array_key_exists('Content-Length', $responseHeaders)) {
// content-length header missing, file is less than max buffer size
if (!array_key_exists('content-length', $responseHeaders)) {
$file = $this->call(
'GET',
"/functions/{$func->getId()}/deployments/{$deployment['$id']}/download",
Expand All @@ -1714,7 +1714,7 @@ private function exportDeploymentData(Func $func, array $deployment): void
$responseHeaders
);

$size = mb_strlen($file);
$size = strlen($file);

if ($end > $size) {
$end = $size - 1;
Expand All @@ -1737,7 +1737,11 @@ private function exportDeploymentData(Func $func, array $deployment): void
return;
}

$fileSize = $responseHeaders['Content-Length'];
$fileSize = $responseHeaders['content-length'];

if ($end >= $fileSize) {
$end = $fileSize - 1;
}

$deployment = new Deployment(
$deployment['$id'],
Expand Down Expand Up @@ -1772,7 +1776,7 @@ private function exportDeploymentData(Func $func, array $deployment): void
$start += Transfer::STORAGE_MAX_CHUNK_SIZE;
$end += Transfer::STORAGE_MAX_CHUNK_SIZE;

if ($end > $fileSize) {
if ($end >= $fileSize) {
$end = $fileSize - 1;
}
}
Expand Down Expand Up @@ -1920,7 +1924,7 @@ private function exportSiteDeploymentData(Site $site, array $deployment): void
$responseHeaders
);

if (!\array_key_exists('Content-Length', $responseHeaders)) {
if (!\array_key_exists('content-length', $responseHeaders)) {
$file = $this->call(
'GET',
"/sites/{$site->getId()}/deployments/{$deployment['$id']}/download",
Expand All @@ -1929,7 +1933,7 @@ private function exportSiteDeploymentData(Site $site, array $deployment): void
$responseHeaders
);

$size = mb_strlen($file);
$size = strlen($file);

if ($end > $size) {
$end = $size - 1;
Expand All @@ -1951,7 +1955,11 @@ private function exportSiteDeploymentData(Site $site, array $deployment): void
return;
}

$fileSize = $responseHeaders['Content-Length'];
$fileSize = $responseHeaders['content-length'];

if ($end >= $fileSize) {
$end = $fileSize - 1;
}

$siteDeployment = new SiteDeployment(
$deployment['$id'],
Expand Down Expand Up @@ -1982,7 +1990,7 @@ private function exportSiteDeploymentData(Site $site, array $deployment): void
$start += Transfer::STORAGE_MAX_CHUNK_SIZE;
$end += Transfer::STORAGE_MAX_CHUNK_SIZE;

if ($end > $fileSize) {
if ($end >= $fileSize) {
$end = $fileSize - 1;
}
}
Expand Down