uucore: share a fluent resource between threads - dd perf + 45%#11220
Open
oech3 wants to merge 1 commit intouutils:mainfrom
Open
uucore: share a fluent resource between threads - dd perf + 45%#11220oech3 wants to merge 1 commit intouutils:mainfrom
oech3 wants to merge 1 commit intouutils:mainfrom
Conversation
Merging this PR will degrade performance by 3.25%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | dd_copy_with_skip |
103.2 KB | 18.4 KB | ×5.6 |
| ⚡ | Memory | dd_copy_default |
99.5 KB | 14.7 KB | ×6.8 |
| ⚡ | Memory | dd_copy_64k_blocks |
162.9 KB | 78.1 KB | ×2.1 |
| ⚡ | Memory | dd_copy_separate_blocks |
178.3 KB | 137.2 KB | +29.95% |
| ⚡ | Memory | dd_copy_partial |
102.9 KB | 18.1 KB | ×5.7 |
| ⚡ | Memory | dd_copy_4k_blocks |
102.9 KB | 18.1 KB | ×5.7 |
| ⚡ | Memory | dd_copy_with_seek |
103.2 KB | 18.4 KB | ×5.6 |
| ⚡ | Memory | dd_copy_1m_blocks |
1.1 MB | 1 MB | +8.17% |
| ⚡ | Memory | dd_copy_8k_blocks |
106.9 KB | 22.1 KB | ×4.8 |
| ⚡ | Simulation | dd_copy_with_skip |
2.1 ms | 2 ms | +6.92% |
| ⚡ | Simulation | dd_copy_1m_blocks |
1.4 ms | 1.2 ms | +11.38% |
| ⚡ | Simulation | dd_copy_4k_blocks |
1.2 ms | 1.1 ms | +12.5% |
| ⚡ | Simulation | dd_copy_8k_blocks |
913.8 µs | 771.7 µs | +18.4% |
| ⚡ | Simulation | dd_copy_64k_blocks |
501.6 µs | 365.2 µs | +37.35% |
| ⚡ | Simulation | dd_copy_with_seek |
2.2 ms | 2 ms | +7.05% |
| ⚡ | Simulation | dd_copy_partial |
455.8 µs | 315.7 µs | +44.36% |
| ❌ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
24.9 ms | 25.7 ms | -3.25% |
Comparing oech3:sort-exec-malloc (a5b65bf) with main (53200b3)
Footnotes
-
48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
a3d65d4 to
9c4c16b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
GNU testsuite comparison: |
Contributor
Author
|
Not too easy |
|
GNU testsuite comparison: |
05d100c to
182f69a
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11236