uucore: replace unsafe mkfifo wrapper with nix crate implementation#11249
Open
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Open
uucore: replace unsafe mkfifo wrapper with nix crate implementation#11249mattsu2020 wants to merge 1 commit intouutils:mainfrom
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Conversation
Replace the unsafe `libc::mkfifo` wrapper with a safe implementation using the `nix` crate. This change improves code safety by eliminating unsafe code blocks and leveraging the well-tested nix crate for system calls. The functionality remains identical - creating named pipes with 0o666 permissions - but now uses a safer, more idiomatic Rust approach.
|
GNU testsuite comparison: |
Contributor
|
I don't know if you have seen it: the redox job in the CI currently fails with: |
Contributor
|
We should open a |
Contributor
|
I think we could remove the |
Contributor
|
@xtqqczze I opened a PR there to remove the gate: nix-rust/nix#2749 |
Contributor
Yes, that's a possibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the unsafe
libc::mkfifowrapper with a safe implementation using thenixcrate. This change improves code safety by eliminating unsafe code blocks and leveraging the well-tested nix crate for system calls. The functionality remains identical - creating named pipes with 0o666 permissions - but now uses a safer, more idiomatic Rust approach.