Application configurable setting to make unconfigured concepts "un-droppable"#620
Open
lrasmus wants to merge 2 commits intouwrit:masterfrom
Open
Application configurable setting to make unconfigured concepts "un-droppable"#620lrasmus wants to merge 2 commits intouwrit:masterfrom
lrasmus wants to merge 2 commits intouwrit:masterfrom
Conversation
"Empty" concepts are those without any query logic defined (explicit WHERE or numeric field). We do not want concepts like this to be used to build queries, although Leaf handles these nicely today (will return a count of everyone). Setting this as an application configuration should support those who might want the feature from those happy with how Leaf has always worked.
Not all uses of the concept panel are droppable, so it doesn't always make sense to require the user to specify the setting. Use a default value for the component instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature comes from a the discussion about non-queryable concepts: #610
As this behavior may not be desired by everyone, there is a new application configuration setting (
Client>FindPatients>AllowEmptyConcepts) which would turn this behavior on or off. If it is set totrue(the default inappsettings.json), Leaf will continue to work as before. If it is set tofalse, any concept not configured with aWHEREcondition or a numeric field to query cannot be dropped on the query panel. In the example below, "Root" and "Grouper" have no query details configured, so when they are dropped on to the panel they snap back.This feature was not requested by any other site than mine (Northwestern), and since it is an unsolicited PR I completely understand if you do not want to accept the change. I attempted to implement it in a way that would preserve Leaf's existing functionality, while giving sites an option to change this behavior if they would ever want it.